Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-components/ouex6g9ao |
Thanks IE
emplums
left a comment
emplums
left a comment
There was a problem hiding this comment.
This is really awesome work 😍 I don't have any feedback, it looks like it's ready to go!
docs/content/Pagination.md
Outdated
| --- | ||
| import State from '../components/State' | ||
|
|
||
| Use the pagination component to create a connected set of links that go to related pages (for example, previous, next, or page numbers). |
There was a problem hiding this comment.
This docs page is above and beyond ✨ nice work!!
| | showPages | Boolean | `true` | Whether or not to show the individual page links. | | ||
| | surroundingPageCount | Number | 2 | How many pages to display on each side of the currently selected page. | | ||
|
|
||
| ## Theming |
There was a problem hiding this comment.
This is a great idea to start doing! Would love to spend time refactoring the current components and creating more component-related objects in the theme, then start documenting that on each docs page
| currentPage: number | ||
| hrefBuilder?: PaginationHrefBuilder | ||
| /** | ||
| * How many pages to show on the left and right of the component |
There was a problem hiding this comment.
Do these comments show up in VSCode when someone is writing TS? That's pretty sweet
There was a problem hiding this comment.
Yeah they power TS intellisense IIRC
3 participants
This PR adds a Pagination component.
Docs and demo: https://primer-components-git-mkt-pagination-component.primer.now.sh/components/Pagination
Closes #672
Targeting minor version release
Merge checklist
index.d.ts) if necessary